WTL-852 Add Terraform configuration#22
Merged
Merged
Conversation
Adrian Grucza (apgrucza)
requested review from
Rodney Marsh (RodneyMarsh),
Antony Nevis (anevis) and
Nitin Shetty (nbshetty)
Adrian Grucza (apgrucza)
changed the title
Patrick Herrera (patrickherrera)
approved these changes
Sep 8, 2021
Patrick Herrera (patrickherrera)
left a comment
Patrick Herrera (patrickherrera)
left a comment
There was a problem hiding this comment.
There is a fair bit in there, but it looks good
| @@ -0,0 +1,13 @@ | |||
| module "cloudfront_auth_okta_native" { | |||
| source = "github.com/iress/cloudfront-auth//infra/terraform/modules/okta_native" | |||
There was a problem hiding this comment.
nit: double slash in path
There was a problem hiding this comment.
This is intentional. The double slash syntax is the way to specify a path inside the repo: https://www.terraform.io/docs/language/modules/sources.html#modules-in-package-sub-directories
There was a problem hiding this comment.
Cool, I did wonder if it was intentional somehow but couldn't for the life of me figure out what it meant
Rodney Marsh (RodneyMarsh)
approved these changes
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving Terraform configuration from the private repository to here