Skip to content

fix: honour url filename when downloading as CAR/BLOCK - #9028

Merged
lidel merged 1 commit into
masterfrom
fix/9027
Jun 9, 2022
Merged

fix: honour url filename when downloading as CAR/BLOCK#9028
lidel merged 1 commit into
masterfrom
fix/9027

Conversation

@hacdias

@hacdias hacdias commented Jun 9, 2022

Copy link
Copy Markdown
Member

Fixes #9027. Please let me know if there is anything else I need to do before this can be merged.

@hacdias
hacdias requested a review from lidel as a code owner June 9, 2022 12:56
@hacdias
hacdias marked this pull request as draft June 9, 2022 13:45

@Jorropo Jorropo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@hacdias
hacdias marked this pull request as ready for review June 9, 2022 14:05

@lidel lidel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this!

@lidel
lidel merged commit 33843bf into master Jun 9, 2022
@lidel
lidel deleted the fix/9027 branch June 9, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Gateway CAR Download Doesn't Respect filename

3 participants