Skip to content

chore: bump go-ipld-format v0.4.0 and fix related sharness tests#8838

Merged
Jorropo merged 3 commits into
ipfs:masterfrom
Jorropo:fix/ErrNotFound-hopefully-final
Apr 5, 2022
Merged

chore: bump go-ipld-format v0.4.0 and fix related sharness tests#8838
Jorropo merged 3 commits into
ipfs:masterfrom
Jorropo:fix/ErrNotFound-hopefully-final

Conversation

@Jorropo

@Jorropo Jorropo commented Mar 31, 2022

Copy link
Copy Markdown
Contributor

@Jorropo Jorropo requested a review from guseggert March 31, 2022 21:04
@Jorropo Jorropo self-assigned this Mar 31, 2022
@Jorropo Jorropo force-pushed the fix/ErrNotFound-hopefully-final branch from a6ee61d to 4c76567 Compare March 31, 2022 22:38
@Jorropo Jorropo force-pushed the fix/ErrNotFound-hopefully-final branch 11 times, most recently from a1cb08e to 16a13ce Compare April 1, 2022 03:06

@schomatis schomatis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jorropo Can we fix lint and related errors to have CI pass? It's hard to tell if this is fixing previously existing errors if new ones are blocking the build.

@Jorropo Jorropo force-pushed the fix/ErrNotFound-hopefully-final branch from 85a6dd5 to a126fbc Compare April 1, 2022 16:13
@Jorropo Jorropo requested a review from schomatis April 1, 2022 16:14
@Jorropo

Jorropo commented Apr 1, 2022

Copy link
Copy Markdown
Contributor Author

@schomatis done!

@Jorropo Jorropo force-pushed the fix/ErrNotFound-hopefully-final branch from a126fbc to ac297a8 Compare April 2, 2022 03:08
@Jorropo

Jorropo commented Apr 5, 2022

Copy link
Copy Markdown
Contributor Author

Merging as discussed in today's meeting.

@Jorropo Jorropo enabled auto-merge April 5, 2022 18:10
@Jorropo Jorropo disabled auto-merge April 5, 2022 18:10
@Jorropo Jorropo enabled auto-merge April 5, 2022 18:27
@Jorropo Jorropo disabled auto-merge April 5, 2022 18:31
@Jorropo Jorropo enabled auto-merge April 5, 2022 18:31
@Jorropo Jorropo merged commit 4df7b79 into ipfs:master Apr 5, 2022
@Jorropo Jorropo deleted the fix/ErrNotFound-hopefully-final branch April 5, 2022 19:08
@Jorropo Jorropo restored the fix/ErrNotFound-hopefully-final branch December 12, 2022 22:32
@Jorropo Jorropo deleted the fix/ErrNotFound-hopefully-final branch December 12, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants