feat: register first block metric by default#8332
Merged
Merged
Conversation
aschmahmann
approved these changes
Aug 9, 2021
aschmahmann
left a comment
aschmahmann
left a comment
Contributor
There was a problem hiding this comment.
LGTM, although I'm not totally sure why we left this out previously. IIRC it's because we were hoping to put together a better metric here, not because of performance issues or anything like that.
@Stebalien does that sounds correct?
Member
|
I can't remember either. But I'd just ship it. |
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
feat: register first block metric by default This commit was moved from ipfs/kubo@0e73e23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an important performance metric that PL uses for gateway monitoring, so enabling it by default.
This is cherry-picked from 44fcc15