Skip to content

[wip] ci: Run ipfs/js-ipfs-http-client & ipfs/interop tests#5053

Closed
magik6k wants to merge 7 commits into
masterfrom
feat/ci-js-api
Closed

[wip] ci: Run ipfs/js-ipfs-http-client & ipfs/interop tests#5053
magik6k wants to merge 7 commits into
masterfrom
feat/ci-js-api

Conversation

@magik6k

@magik6k magik6k commented May 31, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

This PR:

TODO:

  • Make sure the tests actually use provided go-ipfs
  • Try to skip parts that don't touch go-ipfs
  • Make sure tests are stable
  • Deduplicate code with jenkins-libs
  • Collect test results

@magik6k magik6k requested a review from Kubuxu as a code owner May 31, 2018 02:33
@ghost ghost assigned magik6k May 31, 2018
@ghost ghost added the status/in-progress In progress label May 31, 2018
@magik6k magik6k force-pushed the feat/ci-js-api branch 2 times, most recently from 68c2f6d to 971b64f Compare May 31, 2018 02:34
@magik6k magik6k mentioned this pull request Jul 6, 2018
Closed
@magik6k magik6k added the status/blocked Unable to be worked further until needs are met label Jul 6, 2018
@ghost ghost assigned Stebalien Jul 13, 2018
@magik6k magik6k force-pushed the feat/ci-js-api branch 3 times, most recently from b8a2ce5 to 9340c71 Compare August 2, 2018 22:51
@magik6k magik6k removed the status/blocked Unable to be worked further until needs are met label Aug 2, 2018
@magik6k

magik6k commented Aug 3, 2018

Copy link
Copy Markdown
Member Author

I updated js-ipfs-api/interop to latest versions, but there was only 1.5/20 successful passes. the tests also took a ton of time (avg 26min for interop, and ~101min (!) for js-api)

@diasdavid @alanshaw Can you have a look at the failures in https://ci.ipfs.team/job/IPFS/job/go-ipfs/job/PR-5053/? Is that caused by the way the tests are invoked here or could something be broken in go-ipfs master?

@alanshaw

alanshaw commented Aug 7, 2018

Copy link
Copy Markdown
Member

hey @magik6k, awesome to see this PR! 💖

js-ipfs-api tests take around 40 minutes right now (they run against go-ipfs): https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs-api/activity. I'm hoping to decrease that time this quarter.

For the js-ipfs 0.31 release I ran the interop tests locally and they all passed. I believe they were also passing on CI...

I was under the impression these were working on CI also, ipfs/interop#28 ...can't lookup the history as the jobs have been purged already but it looks like it was also failing here.

It would be cool if we could work together to fix this up - I think it's both our responsibilities to create and maintain interop!

@magik6k magik6k mentioned this pull request Aug 26, 2018
Closed
@magik6k magik6k added the status/blocked Unable to be worked further until needs are met label Aug 26, 2018
@magik6k

magik6k commented Oct 29, 2018

Copy link
Copy Markdown
Member Author

So I've rebased this and updated js-ipfs-api/interop commits, and it looks like we've broke some things between now and 0.4.17: https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fgo-ipfs/detail/PR-5053/13/tests

@magik6k magik6k force-pushed the feat/ci-js-api branch 3 times, most recently from 47e9466 to 2cf11ed Compare October 30, 2018 03:51
@magik6k magik6k removed the status/blocked Unable to be worked further until needs are met label Oct 30, 2018
@magik6k magik6k force-pushed the feat/ci-js-api branch 2 times, most recently from bfffaf0 to 30081a2 Compare October 30, 2018 14:09
@magik6k magik6k force-pushed the feat/ci-js-api branch 3 times, most recently from d436b2e to 7e07e41 Compare October 30, 2018 20:56
@Stebalien

Stebalien commented Oct 31, 2018

Copy link
Copy Markdown
Member

Rebased again on #5708.

@magik6k magik6k force-pushed the feat/ci-js-api branch 3 times, most recently from 267484e to 9c98ff4 Compare November 5, 2018 18:44
@magik6k magik6k force-pushed the feat/ci-js-api branch 3 times, most recently from 262459a to 8745a29 Compare December 30, 2018 02:30
@Stebalien

Stebalien commented Feb 8, 2019

Copy link
Copy Markdown
Member

Rebased for an RC.

@Stebalien Stebalien force-pushed the feat/ci-js-api branch 2 times, most recently from b8bb519 to eb0e418 Compare February 9, 2019 00:07
@daviddias daviddias changed the title [wip] ci: Run js-api/interop tests [wip] ci: Run ipfs/js-ipfs-http-client & ipfs/interop tests Feb 11, 2019
magik6k and others added 7 commits February 18, 2019 18:58
@magik6k @Stebalien
ci: Run js-ipfs-api tests
6a5d41b 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k @Stebalien
ci: Run interop tests
e31f991 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k @Stebalien
ci: Disable interop for now
e4b9d24 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k @Stebalien
ci: call cleanWs
138b11a 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k @Stebalien
ci: update interop/js-api
c3a703d 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@Stebalien
interop: update interop tests
9ec1c77 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien
remove old node support
545fce7 
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@magik6k

magik6k commented Jun 5, 2019

Copy link
Copy Markdown
Member Author

We don't have Jenkins anymore.

@magik6k magik6k closed this Jun 5, 2019
@magik6k

magik6k commented Jun 5, 2019

Copy link
Copy Markdown
Member Author

(Don't delete this branch for now though)

@Kubuxu

Kubuxu commented Jun 5, 2019

Copy link
Copy Markdown
Member

If it goes missing and you need it, check go-ipfs-archive.

@hacdias hacdias deleted the feat/ci-js-api branch May 9, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@Stebalien Stebalien

@magik6k magik6k

Labels

status/in-progress In progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@magik6k @alanshaw @Stebalien @Kubuxu @momack2