fix(provider): wait for fullrt crawl completion before providing#11137
Merged
Conversation
gammazero
approved these changes
Jan 9, 2026
lidel
approved these changes
Jan 9, 2026
lidel
left a comment
lidel
left a comment
Member
There was a problem hiding this comment.
lgtm, but I would still do libp2p/go-libp2p-kad-dht#1214 for improved visibility in logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11085
Supersedes libp2p/go-libp2p-kad-dht#1214
Creates a wrapper around the
fullrt.FullRTDHT, whoseGetClosestPeers()method is used by the Sweeping Provider, and makeGetClosestPeers()error as long as the initial network crawl isn't over.It results in the provider being in
Disconnectedstate until the initial network crawl is complete. All provide operations will start when the node comesOnlineafter the crawl is complete. The provider's connectivity status can be monitored with theipfs provide statcommand.I prefer this approach compared with libp2p/go-libp2p-kad-dht#1214, since it doesn't expose the convoluted FullRT implementation details in the
providermodule.