chore: upgrade to go 1.23#10486
Merged
Merged
Conversation
This was referenced Aug 20, 2024
Closed
lidel
commented
Aug 22, 2024
| require ( | ||
| github.com/Kubuxu/gocovmerge v0.0.0-20161216165753-7ecaa51963cd | ||
| github.com/golangci/golangci-lint v1.59.1 | ||
| github.com/golangci/golangci-lint v1.60.2 |
Member
Author
There was a problem hiding this comment.
ℹ️ bumping linter and fixing reported complains made CI green
lidel
added a commit
that referenced
this pull request
Aug 28, 2024
* chore: upgrade to go 1.23 https://tip.golang.org/doc/go1.23 * refactor: golangci-lint v1.60.2 (cherry picked from commit 2260e35)
lidel
added a commit
to ipfs/distributions
that referenced
this pull request
Aug 28, 2024
lidel
added a commit
to ipfs/distributions
that referenced
this pull request
Aug 28, 2024
* chore: add Kubo release * chore: update .tool-versions ipfs/kubo#10486
gammazero
reviewed
Aug 28, 2024
| ) | ||
|
|
||
| go 1.22 | ||
| go 1.23 |
Contributor
There was a problem hiding this comment.
Do we want to require go 1.23 to build kubo? I think we want to keep this at 1.22.
Member
Author
There was a problem hiding this comment.
I think its fine to require, we are not a library and https://github.com/ipfs/distributions/blob/master/.tool-versions uses 1.23 now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GO 1.23 Release Notes: https://tip.golang.org/doc/go1.23
Kubo is not a library, so we can switch to latest version sooner.
This PR aims to see if there are any issues.