Skip to content

fix(cli): unify --name shorthand in pin ls and pin add#10439

Merged
lidel merged 1 commit into
masterfrom
fix/unify-name-shorthand
Jun 6, 2024
Merged

fix(cli): unify --name shorthand in pin ls and pin add#10439
lidel merged 1 commit into
masterfrom
fix/unify-name-shorthand

Conversation

@lidel

@lidel lidel commented Jun 5, 2024

Copy link
Copy Markdown
Member

This is a cosmetic fix for UX bug found during testing 0.29.0-rc2.

  • pin add --name had shorthand -n
  • pin ls --name had no shorthand, and --names had -n

This PR unifies -n making it a shorthand for the same parameter in both pin ls and pin add.

cc #10412 #10398

This is a cosmetic fix for bug found during testing 0.29.0-rc2.
pin add --name had shorthand -n
pin ls --name had no shorthand, and --names had -n

This unifies -n making it a shorthand for the same parameter in both
`pin ls` and `pin add`.
@lidel lidel requested a review from a team as a code owner June 5, 2024 20:11
@lidel lidel mentioned this pull request Jun 5, 2024
9 tasks
@lidel lidel changed the title fix(cli): unify --name param in ls and add fix(cli): unify --name shorthand in pin ls and pin add Jun 5, 2024
@lidel lidel merged commit a07852a into master Jun 6, 2024
@lidel lidel deleted the fix/unify-name-shorthand branch June 6, 2024 20:19
lidel added a commit that referenced this pull request Jun 6, 2024
This is a cosmetic fix for bug found during testing 0.29.0-rc2.
pin add --name had shorthand -n
pin ls --name had no shorthand, and --names had -n

This unifies -n making it a shorthand for the same parameter in both
`pin ls` and `pin add`.

(cherry picked from commit a07852a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant