This repository was archived by the owner on Feb 12, 2024. It is now read-only.
feat: encoding key's name to base32#2410
Closed
AuHau wants to merge 1 commit into
Closed
Conversation
AuHau
force-pushed
the
auhau/feat/encoding_keys_to_base32
branch
3 times, most recently
from
4026069 to
5bad6a5
Compare
9 tasks
Member
|
Hi! js-ipfs master just got a whole new set of automated tests with #2528, #2440 and also running some of the test suites from our early testers (hi5 to @achingbrain for setting it all up!). Would you mind rebasing the master branch on this PR to ensure it runs all the latest tests? Thank you! |
AuHau
force-pushed
the
auhau/feat/encoding_keys_to_base32
branch
from
5bad6a5 to
20a7233
Compare
Related to #1937
AuHau
force-pushed
the
auhau/feat/encoding_keys_to_base32
branch
from
20a7233 to
c236111
Compare
|
Is this actually in progress? |
Member
|
Thank you so much for opening this PR and for your patience in getting it merged. js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide. I don't think this is required any more since Kubo adopted Badger and broke repo compatibility, js-IPFS is free to do what it wants. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tackles #1937. Yet I am not so sure if it is actually needed.
Since how Keystore works (eq. has stored metadata in
/info), it could be easier to just lowercase the filenames instead of encoding them into base32. Yet, if there is a desire to have the same IPFS Repo like withgothen this will be needed. Although I guess it should be actuallygowho should adopt the same pattern for Keystore as is injs(eq. encrypt keys with a passphrase and have metadata aside). Not sure if it is in plan in the near future, though.Blocking PRs: