Skip to content

Peers: assigning nicknames / pet names #1018

Open

Description

@sehejkaw

A peer nickname can be added next to peer ID.

Activity

  1. jessicaschilling commented on Apr 2, 2020

    @jessicaschilling
    Contributor

    @lidel @olizilla and others -- thoughts on feasibility/desirability here? Marking as an issue for discussion for now.

  2. added
    exp/intermediatePrior experience is likely helpful
    effort/daysEstimated to take multiple days, but less than a week
    kind/enhancementA net-new feature or improvement to an existing feature
    need/analysisNeeds further analysis before proceeding
    P3Low: Not priority right now
    status/inactiveNo significant work in the previous month
    topic/design-uxUX strategy, research, not solely visual design
    on Apr 2, 2020
  3. lidel commented on Apr 7, 2020

    @lidel
    Contributor

    The idea of "pet names" was part of #891 but only "Add connection" button was added to the Peers screen. Labeling peers was descoped because while we could implement it in userland (store names in local storage of webui Origin), the names would show only in webui.

    I believe a better way is to add support for this to ipfs swarm * commands and persist them as additional metadata in peerstore that could be read on-demand, similar to existing --direction:

    $ ipfs swarm connect --petname PeeryMcPeer /p2p/QmPeerId
    connect QmPeerId success
    
    $ ipfs swarm peers --petname
    
    /ipv4/somethingelse  OtherNick
    /ipv4/no-petname  
    /ipv4/something      PeeryMcPeer

    That way we can not only support them in webui, but also CLI, RPC API and other tools.

    cc @vasco-santos (from libp2p) if libp2p project discussed adding this type of metadata before

  4. changed the title [-]Addition of nickname[/-] [+]Peers: assigning nicknames / pet names[/+] on Apr 7, 2020
  5. vasco-santos commented on Apr 8, 2020

    @vasco-santos
    Member

    Hey folks!

    I am currently working on improving libp2p's PeerStore on JS land and this is one of the things that I intend to support. By the end of the PeerStore improvements, we should support adding metadata to a peer.

    Regarding API for libp2p and IPFS, we did not start discussing this yet, since my main focus has been the AddressBook, ProtoBook and KeyBook. As soon as we have the former books, I will be working on the MetadataBook, which should be used for this use case. I will keep you posted and we can discuss further this API

  6. vasco-santos commented on May 4, 2020

    @vasco-santos
    Member

    PSA: I wrote my initial thoughts on the MetadataBook for js-libp2p. Depending on the feedback, this might get into the next js-libp2p release work: libp2p/js-libp2p#627

  7. jessicaschilling commented on Aug 20, 2020

    @jessicaschilling
    Contributor

    @vasco-santos - what's the latest status of this? Thanks!

  8. vasco-santos commented on Aug 21, 2020

    @vasco-santos
    Member

    Hey!
    @jessicaschilling well, it is shipped in libp2p, you can add data to the metadatabook as described in the API doc. There is no friendly API in the IPFS side of things so far, like the examples @lidel wrote above.
    For now you can use that feature by doing ipfs.libp2p.peerStore* through the API (no CLI support). You can use .peers to access all the peers if you want to do a "filter" per a specific metadata key later on. This is supported from ipfs@0.47 IIRC

  9. jessicaschilling commented on Aug 21, 2020

    @jessicaschilling
    Contributor

    Thanks, @vasco-santos!

    @lidel - given the current status, do you think this is something that's worth putting out for bounty right now?

  10. lidel commented on Aug 25, 2020

    @lidel
    Contributor

    This is blocked until high level API support for peerstore metadata is present in both js-ipfs and go-ipfs (like #1018 (comment) or even more generic kv approach).

  11. added
    status/blockedUnable to be worked further until needs are met
    and removed
    status/inactiveNo significant work in the previous month
    on Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Low: Not priority right noweffort/daysEstimated to take multiple days, but less than a weekexp/intermediatePrior experience is likely helpfulkind/enhancementA net-new feature or improvement to an existing featureneed/analysisNeeds further analysis before proceedingneed/maintainers-inputNeeds input from the current maintainer(s)status/blockedUnable to be worked further until needs are mettopic/design-uxUX strategy, research, not solely visual design

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions