Skip to content

Fix caller not being added #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kubuxu merged 2 commits into from
Jun 9, 2020
Merged

Fix caller not being added #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
998abca
Fix caller not being added
Kubuxu Jun 9, 2020
54eefc7
Add test
Kubuxu Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions log_level_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ func TestLogLevel(t *testing.T) {
for {
var entry struct {
Message string `json:"msg"`
Caller string `json:"caller"`
}
err := decoder.Decode(&entry)
switch err {
Expand All @@ -30,6 +31,9 @@ func TestLogLevel(t *testing.T) {
if entry.Message != "bar" {
t.Errorf("unexpected message: %s", entry.Message)
}
if entry.Caller == "" {
t.Errorf("no caller in log entry")
}
}
}()
logger.Debugw("foo")
Expand Down
5 changes: 4 additions & 1 deletion setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,10 @@ func getLogger(name string) *zap.SugaredLogger {
if !ok {
levels[name] = zap.NewAtomicLevelAt(zapcore.Level(defaultLevel))
log = zap.New(loggerCore).
WithOptions(zap.IncreaseLevel(levels[name])).
WithOptions(
zap.IncreaseLevel(levels[name]),
zap.AddCaller(),
).
Named(name).
Sugar()

Expand Down