feat: add entrypoint#14
Merged
Merged
Conversation
laurentsenta
force-pushed
the
feat/entrypoint
branch
4 times, most recently
from
4f51f8f to
5ee10a6
Compare
laurentsenta
force-pushed
the
feat/entrypoint
branch
from
5ee10a6 to
75f6d70
Compare
laurentsenta
force-pushed
the
feat/entrypoint
branch
from
09200d5 to
b5423cf
Compare
Contributor
Author
|
Run with subdomain option: |
galargh
reviewed
Mar 16, 2023
galargh
left a comment
galargh
left a comment
Contributor
There was a problem hiding this comment.
Shared a few thoughts inline. I want to play with code a bit to see if clearer ideas emerge.
Contributor
|
Here's what came out of me playing with the entrypoint: #15 I know the diff is awful. Let's just get together tomorrow and talk it through. I think it's going to be easier that way. |
- add support for go test args to the entrypoint - update Go version to 1.20 - rename is-subdomain to subdomain-gateway-spec - add merged as argument to the extract-fixtures command - rename entrypoint as gateway-conformance - rename tests package from main to tests - rename build tag to no_subdomain_gateway_spec - add a utility function for accessing GATEWAY_CONFORMANCE_HOME
feat: turn entrypoint into gateway-conformance CLI
galargh
approved these changes
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces the old entrypoint.sh script with a new one written in Go.
We expect the conformance testing to get more complex and involve optional parameters to enable/disable parts of the test suite (like subdomains), go will be more maintainable here.
We also added the necessary flags to run the new test suite in CI.