routing/http: fix goroutine/memory leak [skip changelog]#618
Merged
Conversation
I've noticed some memory and goroutine buildup, linked to that function. It seems like when the context get cancelled, the consumer could be gone, but that function would still attempt to write in the channel and block forever.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #618 +/- ##
==========================================
- Coverage 59.80% 59.67% -0.13%
==========================================
Files 239 239
Lines 29961 29961
==========================================
- Hits 17917 17880 -37
- Misses 10427 10458 +31
- Partials 1617 1623 +6
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed some memory and goroutine buildup, linked to that function.
It seems like when the context get cancelled, the consumer could be gone, but that function would still attempt to write in the channel and block forever.