fix(gateway): question marks in url.Path when redirecting#313
Merged
Conversation
This was referenced May 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #313 +/- ##
==========================================
- Coverage 50.62% 50.13% -0.50%
==========================================
Files 280 280
Lines 33724 33714 -10
==========================================
- Hits 17074 16901 -173
- Misses 14870 15029 +159
- Partials 1780 1784 +4
|
c1c828e to
28b1b54
Compare
whizzzkid
reviewed
May 25, 2023
lidel
approved these changes
Jun 2, 2023
lidel
left a comment
Member
There was a problem hiding this comment.
I've tested this in Kubo (ipfs/kubo#9894) and works as expected.
I've resolved conflicts in 77afd71 and tested again locally, still good.
Merging, to bubble up to ipfs/kubo#9894.
@hacdias please see my comment there for next steps 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ipfs/kubo#9882, fixes ipfs/ipfs-companion#1201. I updated
toSubdomainURLto use theurl.URLstruct from Go to build the final URL. The problem was thatrestwas the original, decoded,r.URL.Pathand it contains a?. When Go parses it, it'd consider it as a query element, rightly so.Kubo PR: ipfs/kubo#9894