tools/cpudist: Add extension summary support#4131
Merged
yonghong-song merged 2 commits intoiovisor:masterfrom Jul 29, 2022
Merged
tools/cpudist: Add extension summary support#4131yonghong-song merged 2 commits intoiovisor:masterfrom
yonghong-song merged 2 commits intoiovisor:masterfrom
Conversation
xingfeng2510
requested review from
brendangregg,
davemarchevsky and
goldshtn
as code owners
xingfeng2510
force-pushed
the
fixup
branch
4 times, most recently
from
d9fc74f to
bf768c7
Compare
Collaborator
|
LGTM. The implementation is very similar to biolatency.py. |
chenhengqi
added a commit
to chenhengqi/bcc
that referenced
this pull request
Aug 6, 2022
With iovisor#4131 included, running the tool with -L reports the following warning: /virtual/main.c:57:28: warning: multi-character character constant [-Wmultichar] pid_key_t key = {.id = ' + pid + ', .slot = bpf_log2l(delta)}; ^ /virtual/main.c:57:28: warning: character constant too long for its type 2 warnings generated. The `pid` part should not be treated as string literal. Fix it. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, I want to known total on-CPU or off-CPU time and count (same as context switch times) at a fixed interval (for example: 1s).
Like #3384, This patch try to add an option -e to show extension summary (average/total/count).
@yonghong-song Please take a look, thanks.