fix(tab-bar): fire tab change events on tab click#31262
Merged
Conversation
…DidChange in onTabButtonClick change incorrect references `this.props.onIonTabs[Did/Will]Change` to `this.props.tabsContext.tabBarProps.onIonTabs[Did/Will]Change` inside React IonTabBar onTabButtonClick closes ionic-team#30145
|
@droc101 is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
ShaneK
requested changes
Jul 10, 2026
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
Looking good, just a change request and test request
ShaneK
changed the title
….tabsContext?.tabBarProps.onIonTabs[Did/Will]Change is not available
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
approved these changes
Jul 13, 2026
ShaneK
left a comment
ShaneK
left a comment
Member
There was a problem hiding this comment.
Looks good to me! Awesome work 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30145
What is the current behavior?
ionic-react'sIonTabBartries to referencethis.props.onIonTabsWillChangeandthis.props.onIonTabsDidChange, which do not exist, causing theonIonTabsWillChangeandonIonTabsDidChangeevents to never fire.What is the new behavior?
this.props.onIonTabsWillChangetothis.props.tabsContext.tabBarProps.onIonTabsWillChangethis.props.onIonTabsDidChangetothis.props.tabsContext.tabBarProps.onIonTabsDidChangethis.props.tabsContextis truthy before using itonIonTabsWillChangeandonIonTabsDidChangefire as expectedDoes this introduce a breaking change?