This repository was archived by the owner on May 1, 2020. It is now read-only.
fix(sass sourcemaps): output valid source maps, that chrome can parse#306
Merged
danbucholtz merged 8 commits intoionic-team:masterfrom Jan 28, 2017
Merged
fix(sass sourcemaps): output valid source maps, that chrome can parse#306danbucholtz merged 8 commits intoionic-team:masterfrom
danbucholtz merged 8 commits intoionic-team:masterfrom
Conversation
Contributor
Author
|
please merge, so scss sourcemaps would work again. they are still broken @ionic/app-scripts v 0.0.43 |
Contributor
|
Thanks! Thanks, |
|
Thanks for this. I'm trying this on Ionic App Scripts Version: 1.0.1 but doesn't seem to work. I'm using I tried this as well I don't see any or any inline source maps the end of Info: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
#46
sourcemaps for sass are broken
Changes proposed in this pull request:
Fixes: #
output the full sourcemap, not only the mappings-property