This repository was archived by the owner on May 1, 2020. It is now read-only.
fix(sourcemaps) copy vendor.js.map#1396
Open
HugoHeneault wants to merge 1 commit intoionic-team:masterfrom
HugoHeneault:fix/keep-vendor-sourcemap
Open
fix(sourcemaps) copy vendor.js.map#1396HugoHeneault wants to merge 1 commit intoionic-team:masterfrom HugoHeneault:fix/keep-vendor-sourcemap
HugoHeneault wants to merge 1 commit intoionic-team:masterfrom
HugoHeneault:fix/keep-vendor-sourcemap
Conversation
Contributor
|
@HugoHeneault I think we excluded it by default in the beginning because the generated source map file is usually pretty large. It may be better to have this behind an option? |
Author
|
@dwieeb Sure! If I remember right I think polyfill.js was also missing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Keep vendor.js.map instead of ignoring it
Changes proposed in this pull request:
Fixes: # might partially fix #1235 (for the missing vendor part)