Add universal noise and optional denoiser noise inputs#9044
Open
JPPhoto wants to merge 3 commits intoinvoke-ai:mainfrom
Open
Add universal noise and optional denoiser noise inputs#9044JPPhoto wants to merge 3 commits intoinvoke-ai:mainfrom
JPPhoto wants to merge 3 commits intoinvoke-ai:mainfrom
Conversation
ea8955c to
95915db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
Universal Noiseinvocation for architecture-specific latent noise generation and extends supported denoise invocations to accept optional externalnoiseinputs while preserving existing behavior whennoiseis not connected. This backwards compatibility means that existing workflows, including those generated by the canvas and linear frontend, continue to work without modification because all newnoiseinputs are optional and default to the existing internal noise-generation path.Backend changes cover
FLUX,FLUX.2,SD3,CogView4,Z-Image, andAnimadenoisers, plus focused validation and regression tests. Frontend-facing schema was regenerated so the new invocation and denoisenoiseinputs are available ininvokeai/frontend/web/src/services/api/schema.ts. Documentation was updated ininvokeai/docs/contributing/NEW_MODEL_INTEGRATION.mdto require extendingUniversal Noisewhen possible for new architectures that support external noise.Also added inline denoiser documentation for the existing img2img scheduler-parity limitations, wrote tests for these limitations, and preserved explicit regression coverage by marking the known scheduler-mismatch cases as expected failures rather than dropping those tests.
Related Issues / Discussions
QA Instructions
Try different models using the new
Universal Noisenode as noise input. Verify that it works with different start points and existing input latents whether using the added noise or leaving it off.Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)