Skip to content

fix(android): generate version for ReactNativeFirebaseAppRegistrar.java#3766

Merged
russellwheatley merged 6 commits intomasterfrom
@russell/android-version
Jun 10, 2020
Merged

fix(android): generate version for ReactNativeFirebaseAppRegistrar.java#3766
russellwheatley merged 6 commits intomasterfrom
@russell/android-version

Conversation

@russellwheatley
Copy link
Copy Markdown
Member

fixes #3716

@Salakar Salakar marked this pull request as ready for review June 10, 2020 13:50
Copy link
Copy Markdown
Contributor

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ship it

@Salakar Salakar changed the title build(android): Script that generates version for ReactNativeFirebaseAppRegistrar.java fix(android): generate version for ReactNativeFirebaseAppRegistrar.java Jun 10, 2020
@russellwheatley russellwheatley merged commit 1324985 into master Jun 10, 2020
@russellwheatley russellwheatley deleted the @russell/android-version branch June 10, 2020 13:59
andersondanilo pushed a commit to vixtech/react-native-firebase that referenced this pull request Nov 9, 2020
…va (invertase#3766)

* build(android): script for version

* chore(android): rm ReactNativeFirebaseAppRegistrar

* build(android): create new version class

* chore(android): update script file name

* chore(app, android): formatting

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
[publish]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot find symbol variable VERSION_NAME

2 participants