[raft/scd] Extract update and create opintent - #1655
Open
MariemBaccari wants to merge 1 commit into
Open
Conversation
barroco
added
the
dss-raft
MariemBaccari
force-pushed
the
scd_extract_update_create_opintent
branch
3 times, most recently
from
August 20, 2026 10:50
a3d311c to
2039b92
Compare
This was referenced Aug 20, 2026
MariemBaccari
force-pushed
the
scd_extract_update_create_opintent
branch
6 times, most recently
from
August 21, 2026 14:49
9fc4cb3 to
f6c373b
Compare
MariemBaccari
marked this pull request as ready for review
August 21, 2026 14:52
This was referenced Aug 28, 2026
MariemBaccari
force-pushed
the
scd_extract_update_create_opintent
branch
from
August 28, 2026 10:11
f6c373b to
c5604fb
Compare
This was referenced Aug 28, 2026
This was referenced Aug 28, 2026
mickmis
reviewed
Aug 31, 2026
MariemBaccari
force-pushed
the
scd_extract_update_create_opintent
branch
5 times, most recently
from
September 8, 2026 15:19
0d6721d to
61358c3
Compare
mickmis
approved these changes
Sep 9, 2026
Comment on lines
-206
to
-209
| manager, err := actions.CheckUpsertPermissionsAndReturnManager(authorizedManager, validParams.State) | ||
| if err != nil { | ||
| return nil, nil, stacktrace.PropagateWithCode(err, dsserr.PermissionDenied, "Caller is not allowed to upsert with the requested state") | ||
| } |
Contributor
There was a problem hiding this comment.
- looks like this should be invoked in REST handler for validation
- and could actually be dropped in the
ExecutePutOperationalIntentReferencefunction: if validated the only thing it returns isdssmodels.Manager(*authorizedManager.ClientID)
Contributor
Author
There was a problem hiding this comment.
Addressed in latest push
| if err != nil { | ||
| // responseConflict is non-nil here on a dsserr.MissingOVNs error: return it alongside | ||
| // the error so the handler can still send it to the client. See the doc comment above. | ||
| return &PutOperationalIntentReferenceResult{Conflict: responseConflict}, stacktrace.PropagateWithCode(err, stacktrace.GetCode(err), "Failed to validate key") |
Contributor
There was a problem hiding this comment.
This is the only instance of returning an error from the execute function while still returning a 'valid' response. I think this is confusing, unnecessary and we should get rid of it. Of dsserr.MissingOVNs too. And in the HTTP handler we can just check for a non-nil result.Conflict. WDYT? (does not have to be in this PR)
Contributor
Author
There was a problem hiding this comment.
I agree, thanks for suggesting this. I just opened #1690 to address the comment.
MariemBaccari
force-pushed
the
scd_extract_update_create_opintent
branch
from
September 9, 2026 14:31
61358c3 to
d17c86d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chained PR: #1627 -> #1642 -> #1643 -> #1644 -> #1645 -> #1646 -> #1649 -> #1650 -> #1651 -> #1653 -> #1654 -> #1656 -> #1657 -> #1655 -> #1666 -> #1667 -> #1668 -> #1669
Extract update and create opintent business logic.