Open
Conversation
- refactor fast-feedback.service to use lazy loading for notifications - update home.service.spec to include additional service mocks - enhance hubspot.service.spec with experience object handling - modify ngx-embed-video.service.spec for dynamic id generation - adjust notifications.service to use dynamic imports for components - revise review.service.spec to align with new modal method - fix unlock-indicator.service.spec to use correct subject - update utils.service.spec to improve mobile detection logic - enhance mocked.service and utils.ts for better test coverage
…ic pages - implement tests for date formatting and calendar URL generation - enhance review desktop page tests for various scenarios - improve settings page tests with modal and user profile updates - add tests for tabs page functionality and keyboard navigation - include topic mobile page tests for task handling and navigation
- add ModalController provider to TopicComponent and HomePage specs - fix popUpReviewRating calls to use notificationsService instead of reviewService - add assessmentSubmittedToast to NotificationsService spy in assessment spec - fix boolean return type in chat-preview isBrowserSupportedVideo - fix chat-room spec duplicate spyOn and isQuillContentEmpty mock - update multi-team-member-selector expected value to plain array - update multiple component review answer to array format - fix assessment service spec: add projectBrief, hasReviewRating, correct status - add null-safe access for form.nativeElement in assessment component - add team$ observable to SharedService spy in home page spec - fix topic component spec spy reuse and remove wrong expectation - add showProjectHub to featureToggle in auth-registration spec and fixtures - fix pusher service spec missing closing bracket - fix activity component spec type cast for getTeamInfo observable
- implement tests for handling pristine and dirty states - normalize non-array answers in review and assessment modes - preserve control values when dirty in both modes
- add tests for default input values in bottom action bar - implement click event handling tests in bottom action bar - add review mode tests for file upload component - enhance multi-team member selector tests for selection logic - implement trigger save tests in multiple component - add tests for oneof component save actions and audience checks - enhance slider component tests for save actions and display logic - add team member selector tests for save actions and display logic - implement text component tests for saved answers handling
trtshen
force-pushed
the
unit-test-reinstate
branch
from
611f4a2 to
8b0fb49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage updates: