Skip to content

Updates to validating with Rego and CEL#13

Merged
devopstoday11 merged 3 commits into
mainfrom
patch3
Feb 14, 2024
Merged

Updates to validating with Rego and CEL#13
devopstoday11 merged 3 commits into
mainfrom
patch3

Conversation

@santoshkal

@santoshkal santoshkal commented Dec 19, 2023

Copy link
Copy Markdown
Collaborator

This PR adds more validation features to Genval.

@MrAzharuddin

@chandu-intelops

Copy link
Copy Markdown
Contributor

@santoshkal , resolve the conflicts please

@azar-writes-code azar-writes-code left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@santoshkal , Please move the build file to root and make it executable anywhere.
Instead of ./genval , This should be genval [Command]

@azar-writes-code azar-writes-code left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@santoshkal ,

Please look at the comment and add autocompletion as well and fix in the next PR.
While reviewing, got some conflicts, Please resolve and getback with the above mentioned changed required.

@chandu-intelops @devopstoday11 FYI

Signed-off-by: santoshkal <ksantosh@intelops.dev>
@santoshkal

santoshkal commented Feb 8, 2024

Copy link
Copy Markdown
Collaborator Author

@santoshkal , resolve the conflicts please

got some conflicts, Please resolve and getback with the above mentioned changed required.

Thanks for the review @MrAzharuddin

Resolved the conflicts and is now ready to be merged.
@devopstoday11

@santoshkal

Copy link
Copy Markdown
Collaborator Author

@santoshkal , Please move the build file to root and make it executable anywhere. Instead of ./genval , This should be genval [Command]

Update the Makefile path for genval executable to cwd instead of ./bin/genval currently.
Thanks!

… ./bin/genval currently

Signed-off-by: Santosh Kaluskar <ksantosh@intelops.dev>
Signed-off-by: Santosh Kaluskar <ksantosh@intelops.dev>
@devopstoday11 devopstoday11 merged commit d351f45 into main Feb 14, 2024
@santoshkal santoshkal deleted the patch3 branch April 13, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants