Skip to content
This repository was archived by the owner on Feb 11, 2026. It is now read-only.

promote js-yaml from devDependencies#68

Merged
vishnoianil merged 1 commit intoinstructlab:mainfrom
Gregory-Pereira:remove-omit-dev
Jul 11, 2024
Merged

promote js-yaml from devDependencies#68
vishnoianil merged 1 commit intoinstructlab:mainfrom
Gregory-Pereira:remove-omit-dev

Conversation

@Gregory-Pereira
Copy link
Copy Markdown
Collaborator

@Gregory-Pereira Gregory-Pereira commented Jul 11, 2024

Signed-off-by: greg pereira <grpereir@redhat.com>
@vishnoianil
Copy link
Copy Markdown
Contributor

Unfortunately we can verify if this works or not by merging it. So let's merge and see if the job passes.

@vishnoianil vishnoianil changed the title removing omit dev from install promote js-yaml from devDependencies Jul 11, 2024
Copy link
Copy Markdown
Contributor

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnoianil vishnoianil merged commit a58e3d1 into instructlab:main Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image publishing github workflow is broken

2 participants