Repository navigation
getBestNapiBuildVersion() fails on Node 23.6.0 #6
Description
Node 23.6.0 increased the napi version to 10 - the first napi version to have double digits. This causes getBestNapiBuildVersion (and perhaps other functions too) to fail to produce the correct version:
$ cat package.json | jq '.binary'
{
"napi_versions": [
4
]
}
$ node --version
v23.5.0
$ node -p "require('napi-build-utils').getBestNapiBuildVersion()"
4
$ nvm use 23.6.0
$ node --version
v23.6.0
$ node -p "require('napi-build-utils').getBestNapiBuildVersion()"
undefinedThe root cause is string comparison instead of numeric comparison - until we reached 10, when napiBuildVersion <= ourNapiVersion compared strings, the result was the same as though they were numbers. Now its using lexographic comparison, and napiBuildVersion <= ourNapiVersion -> '4' <= '10' -> 'false'.
Activity
Fix typos and md lint errors
Add GitHub Action for npm tests
Update GitHub Action to register it
Update code for Node-API v10
Remove obsolete CI files
Update README
Update README, remove dev branch dependencies
Bump package version to 2.0.0
jschlight commentedon Jan 17, 2025
This issue should now be addressed in
2.0.0.