Repository navigation
fix(security): fail closed on campaign metadata - #580
Merged
Merged
Conversation
Validate NODEVS and wallet budget declarations semantically, and report their validity in nsaudit machine output. Prevent unattended red-team campaigns from blocking on approval dialogues while preserving deny-only behavior and audited decisions. Fixes INFR-440 Fixes INFR-441 Fixes INFR-442
pdfinn
force-pushed
the
fix/infr-440-442
branch
from
August 31, 2026 22:01
3c899cd to
bdcf652
Compare
Member
Author
|
Merge status: focused host tests, dis-build, style, ring-fence, source hardening, CodeQL, cppcheck, Flawfinder, and SBOM checks pass. The ClusterFuzzLite failure is the pre-existing |
This was referenced Sep 2, 2026
6 of 7 tasks
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nsauditreject missing or malformed NODEVS metadata and wallet budgets fail closedheadless-deniedresultSecurity rationale
The R3 campaign showed that arbitrary non-empty metadata could suppress high-severity findings. It also showed that
malformed9pplus9p-delegation-raceaccidentally matched the oldrm/-rsubstring gate and blocked an unattended child indefinitely.Headless mode remains deny-only: it cannot preauthorize an operation or widen a namespace.
Tests
lucibridge_approval_test.dis: 25 passedtests/host/nsaudit_metadata_test.sh: 16 passedtests/host/nsaudit_rules_test.sh: 22 passedtests/host/nsaudit_profiles_test.sh: passedtests/host/nsaudit_path_semantics_test.sh: passedtests/host/grind_escape_test.sh: passedgit diff --checkFixes INFR-440
Fixes INFR-441
Fixes INFR-442