Repository navigation
visionfs: a setting changed under a reader no longer ends its feed (frozen boxes after place dla0) - #1154
Open
pdfinn wants to merge 4 commits into
Open
visionfs: a setting changed under a reader no longer ends its feed (frozen boxes after place dla0)#1154pdfinn wants to merge 4 commits into
pdfinn wants to merge 4 commits into
Conversation
A place, threshold, classes, model or rate change starts a new follower for the same feed. It stopped the old one with stopfeed, which marks the feed ended and answers every waiting reader with end of file. A layer bound into a camera's (wm/camera, Matrix's video-pane) took that as its end: the boxes froze where they were until the layer was unmounted and bound again. Seen in the vision demo at `echo place dla0 > /mnt/vision/N/ctl`. The restart now only kills the old follower (killfeed); the frame numbers go on, and a reader takes the new follower's next frame. vision_feed_test.sh changes thresh under a reader of a camera's session and reads three more frames from the same open file.
…f file; CHANGELOG
…es to #1152 # Conflicts: # CLAUDE.md
pdfinn
added a commit
that referenced
this pull request
Nov 10, 2026
# Conflicts: # CLAUDE.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the frozen recognition boxes in the vision demo. After
echo place dla0 > /mnt/vision/N/ctl, wm/camera kept drawing the last boxes. They updated again only after the layer was unmounted and bound again.Cause
restartin visionfs's settings). So does a change of threshold, classes, model or rate.stopfeed. That marks the session ended and answers every waiting reader with end of file.It isn't specific to the DLA: any of those settings does the same.
Fix
The restart only kills the old follower (
killfeed). The sequence numbers continue, so a reader takes the new follower's next frame.src nonestill ends readers, as before.Test
tests/host/vision_feed_test.sh, against a camera (camsrv -t):catreads the session's detections in the background, which stops at end of file as a layer's reader does. The threshold changes from 0.3 to 0.45 whilecatis waiting, and its output must keep growing.Run on the Jetson with the yolox-nano model:
catstopped at 6 then 6 lines (fails)My first two versions of the check didn't reproduce the bug. One used shell
reads that weren't waiting at the restart. The other wrotethresh 0.3, which is the default, so nothing restarted.Two notes on that run:
still.jpgshows a person. The live and camera checks pass.