Accept None value in ZstdCompressor/ZstdDecompressor constructors parameters#153
Closed
rodrigozhou wants to merge 2 commits into
Closed
Accept None value in ZstdCompressor/ZstdDecompressor constructors parameters#153rodrigozhou wants to merge 2 commits into
rodrigozhou wants to merge 2 commits into
Conversation
indygreg
requested changes
Jul 5, 2021
Owner
indygreg
left a comment
indygreg
left a comment
There was a problem hiding this comment.
This patch seems reasonable to me and fixes an unwanted divergence in behavior between the C and CFFI backends.
Could you please add a test that verifies that None arguments work? This will help ensure the different backends have consistent behavior.
indygreg
approved these changes
Oct 16, 2021
Owner
indygreg
left a comment
indygreg
left a comment
There was a problem hiding this comment.
This looks good to me!
I'm going to tweak the commits up slightly as part of rebasing. But I will preserve your author annotation so you get credit for the change.
Thank you for this contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change constructors of
ZstdCompressorandZstdDecompressorto accept explicitNonevalue for optional parameters (eg:dict_data). Also changing stubs to reflect this.