Skip to content

Update baseline#358

Merged
inducer merged 4 commits into
inducer:mainfrom
alexfikl:fix-pyright
Jun 23, 2026
Merged

Update baseline#358
inducer merged 4 commits into
inducer:mainfrom
alexfikl:fix-pyright

Conversation

@alexfikl

@alexfikl alexfikl commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

New numpy is out with typing changes 😁 All of the new errors seem to complain that some annotation is partially unknown..

@alexfikl

alexfikl commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Hm, most if not all of these errors seem to be due to numpy 2.5 using typing stuff specific for Python 3.12, e.g.

@runtime_checkable
class _SupportsArray[DTypeT: np.dtype](Protocol):
    def __array__(self) -> np.ndarray[Any, DTypeT]: ...

This makes the whole protocol Unknown for pyright with a bound on Python 3.10.

@inducer

inducer commented Jun 23, 2026

Copy link
Copy Markdown
Owner

Ugh. I think the 0.18 bound for optype was the wrong call then. Sorry! Let's unwind that.

@inducer

inducer commented Jun 23, 2026

Copy link
Copy Markdown
Owner

(And, consequently, bump the basedpyright python version to 3.12.)

@alexfikl

Copy link
Copy Markdown
Contributor Author

Ugh. I think the 0.18 bound for optype was the wrong call then. Sorry! Let's unwind that.

Yeah.. I'm guessing they were in cahoots about that and made the releases match :\

@inducer inducer merged commit 3778e92 into inducer:main Jun 23, 2026
16 checks passed
@inducer

inducer commented Jun 23, 2026

Copy link
Copy Markdown
Owner

Thank you!

@alexfikl alexfikl deleted the fix-pyright branch June 23, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants