Repository navigation
fix(web): pull request linked-thread count uses a link icon - #567
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the pull request panel, the button that shows how many threads link to the pull request used the same speech-bubble icon as the pull request's comment count. It read as a comment count, not a thread count.
The button now uses the link icon, matching its "Linked from N threads" tooltip and the existing "Link to thread" menu item. The thread rows in the link picker and the command palette keep the speech-bubble icon, which is how threads are shown there.
This icon comes from upstream (pingdotgg#10839), and current upstream still uses the speech-bubble icon, so this is a small fork difference in
PullRequestThreadLinks.tsx.Validation
In a local web dev server seeded with a copy of real data, I opened a fork pull request that links to one thread and hovered the count button. It shows the link icon and a count of 1 next to "Check out", and the tooltip still reads "Linked from 1 thread. Search in the command palette." The before image comes from the same view with the old icon restored. The web typecheck and lint on the changed file pass.
Written by an agent (Claude Code, claude-opus-5-5).