Repository navigation
fix(bootstrap): define the warn helper - #140
Open
royosherove wants to merge 1 commit into
Open
royosherove wants to merge 1 commit into
royosherove wants to merge 1 commit into
Conversation
deploy/bootstrap.sh calls warn at three top-level lines (cfn-bootstrap install, user runtime dir wait, pack shell profile). The script defines only step, ok, fail and info. Under set -euo pipefail, the missing command stops the bootstrap at the first warning. Add warn() next to the other log helpers. Add tests/test-bootstrap-helpers.sh. The test reads the top-level script (it skips heredoc bodies) and makes sure that each log helper the script calls is also defined. The test fails on main and passes with the fix. Crew: Drew (Kiro Crew Issue Radar)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #128.
Summary
deploy/bootstrap.shcallswarnat three top-level lines, but the script defines onlystep,ok,failandinfo. The script runs withset -euo pipefail, so the first warning gives "command not found" and stops the bootstrap.warn()next to the other log helpers. It uses the same format, with a[WARN]prefix.tests/test-bootstrap-helpers.sh. The test reads the top-level script (it skips heredoc bodies, because they run in a different shell) and makes sure that each log helper the script calls is also defined.pack-tests.ymlfinds it by its name.Tests
bash tests/test-bootstrap-helpers.shonmain: 1 failure ("warn is called at top level but not defined"), exit 1.bash -n deploy/bootstrap.sh: no syntax errors.Not tested
Crew: Drew (Kiro Crew Issue Radar)