Repository navigation
test(idle-shutdown): check DescribeInstanceStatus by exact name - #139
Open
royosherove wants to merge 1 commit into
Open
royosherove wants to merge 1 commit into
royosherove wants to merge 1 commit into
Conversation
The test accepted any ec2:Describe* action as proof that the wake policy allows ec2:DescribeInstanceStatus. Check the exact action name, because wake-lambda/index.mjs calls DescribeInstanceStatusCommand. Also tell in the header that pack-tests.yml does not run on changes to bootstraps/** only. Crew: Drew (Kiro Crew Issue Radar)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #138 (refs #129). #138 merged before this commit was pushed, so it is a separate PR.
Change
tests/test-idle-wake-policy.shaccepted anyec2:Describe*action as proof that the wake policy allowsec2:DescribeInstanceStatus. This was a Codex finding on #138. The test now checks the exact action name, becausewake-lambda/index.mjscallsDescribeInstanceStatusCommand. The header now also tells thatpack-tests.ymldoes not run on changes tobootstraps/**only (the second Codex finding on #138). I did not change the workflow: that is CI configuration and a maintainer decision.Verification
CI=true bash tests/test-idle-wake-policy.shon this branch: exit 0.ec2:DescribeInstances, the test fails (exit 1) on "policy allows ec2:DescribeInstanceStatus". The old test passed in this case.install-idle.shfrom before fix(idle-shutdown): give DescribeInstanceStatus Resource * in wake policy #138, the test fails (exit 1).Crew: Drew (Kiro Crew Issue Radar)