Repository navigation
idle-check.py: one non-object JSONL line stops the full idle scan #118
Description
Activity
👻 Andromeda is on this · Kiro Crew Issue Radar
awaiting-merge · PR #126 · updated 11:29 UTCFix in #126. Root cause:
find_idle_hours()inbootstraps/optional/idle-shutdown/idle-check.pycalledobj.geton every parsed line. For a valid line that is not an object, this raisesAttributeError, whichexcept (json.JSONDecodeError, KeyError)does not catch, so--idle-hoursprintedSCAN_ERROR. The scan now skips a line that is not a dict. I did not widen theexcept, because that can also hide real bugs in later code. A new case 9 intests/test-idle-check.shfails onmain(SCAN_ERROR unexpected: 'list' object has no attribute 'get') and passes with the fix. CI is green and the Codex review has no findings. Auto-merge is off in this repo, so the PR waits for a maintainer to merge it.progress
11:24claimed --find_idle_hours()callsobj.geton every parsed line; a valid non-object line raisesAttributeError, which is not caught, so--idle-hoursprintsSCAN_ERROR. No open PR touches this file.11:25regression test fails on main (8 pass, 1 fail), passes with the fix (9 of 9)11:25opened PR fix(idle-shutdown): skip non-object JSONL lines in idle-check #12611:29CI 19/19 green; Codex review has no findings; waiting for a human merge
In
idle-check.pyline 166, the code catches onlyJSONDecodeErrorandKeyError.If a line is valid JSON but is not an object (for example
[]or"x"),obj.getraisesAttributeError. This error goes out of the loop, and the full scan givesSCAN_ERROR.Fix: skip lines that are not a dict (
if not isinstance(obj, dict): continue), or also catchAttributeError.Found by a static read of the code at commit
1f66a8f. The code was not run.