Repository navigation
Release 0.1.2 - #3
Merged
Merged
Conversation
tsc cannot resolve the route module imports until @tanstack/router-plugin runs (which happens during `vite build`), so the prior workflow ordering aborted CI on a clean clone. Co-authored-by: Cursor <cursoragent@cursor.com>
Runs build + typecheck on every non-main push and on every PR targeting main, so a broken release branch is caught before it gets merged. Mirrors release.yml ordering (build before typecheck for the same routeTree.gen.ts reason). Co-authored-by: Cursor <cursoragent@cursor.com>
The release workflow used to fire automatically on push-to-main, which meant main could carry a "merged release" commit whose npm publish later failed. New shape: trigger is `workflow_dispatch` on a release/x.y.z branch. Sequence is publish-then-merge: validate branch ↔ version → gate on PR + green CI → build → typecheck → refuse if already on npm → npm publish → squash-merge PR → delete branch → tag vX.Y.Z → GH release A failed publish leaves main untouched and the branch intact, so the operator can fix it and re-run. CONTRIBUTING.md updated to walk through the new flow. Co-authored-by: Cursor <cursoragent@cursor.com>
Reshape the release pipeline so the user's only interaction is clicking "Enable auto-merge (squash)" on a release/x.y.z → main PR. - release.yml now triggers on `pull_request.auto_merge_enabled` and `synchronize`, runs only when auto-merge is on and head is release/x.y.z, then publishes to npm. Its job's success produces a `release` status check. - tag.yml is new. It runs on push-to-main and tags `vX.Y.Z` (plus a GitHub release) iff package.json's version is on npm and not yet tagged. This decouples tagging from the publish path so a botched publish never leaves a hanging tag. - CONTRIBUTING.md walks through the new one-click flow. Branch protection must add `release` as a required status check after this PR lands, so future PRs can't merge without a successful publish. Co-authored-by: Cursor <cursoragent@cursor.com>
The previous version used a job-level `if: auto_merge != null` to skip publishing when auto-merge wasn't enabled. That breaks the gate: GitHub treats a SKIPPED job as a passing required status check, which would let release PRs merge without ever publishing. Now the job-level `if` only skips for *non*-release branches (so docs/refactor PRs still merge with just CI green). For release/x.y.z PRs the job always runs and the first step explicitly `exit 1`s when auto-merge isn't enabled — producing a RED `release` check that blocks merge until the operator clicks "Enable auto-merge". Co-authored-by: Cursor <cursoragent@cursor.com>
Drop the auto-merge gating dance. CI on PRs is the safety net (gates the merge button), and on push-to-main the Release workflow checks package.json's version against npm — publishing + tagging if new, no-op otherwise. Non-release merges (docs, refactors) become quiet no-ops because their version is already on npm. - release.yml: triggers on push-to-main, all heavy steps gated on `version not yet on npm`. Tagging + GH release inlined (tag.yml is gone). - tag.yml: removed (folded into release.yml). - CONTRIBUTING.md: rewritten to the simpler flow. Co-authored-by: Cursor <cursoragent@cursor.com>
The push-event check_run is already visible on PRs (it's tied to the same head SHA), so listening to both push and pull_request just doubled every run with no extra signal. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Pull request overview
Releases version 0.1.2, which is functionally identical to 0.1.1 but reorders the CI/release pipeline to build before typecheck so that src/routeTree.gen.ts (generated by @tanstack/router-plugin during build) exists when tsc runs. Also introduces a dedicated CI workflow used as the required PR status check.
Changes:
- Bump
package.jsonversion to 0.1.2. - Add new
.github/workflows/ci.ymlrunning build → typecheck on non-main branches. - Reorder Release workflow to build before typecheck, restructure with an early
npm viewskip gate, and replacesoftprops/action-gh-releasewith agh release createcall. UpdateCONTRIBUTING.mdaccordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Version bump 0.1.1 → 0.1.2. |
| CONTRIBUTING.md | Documents new CI gate, release flow, and NPM_TOKEN secret. |
| .github/workflows/release.yml | Adds early skip gate, reorders build before typecheck, switches to gh release create for tagging. |
| .github/workflows/ci.yml | New CI workflow (build + typecheck) on non-main branches. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Two intents that future agents need to handle uniformly: - "release" / "发布": pre-flight (branch, dirty tree, version match, pushed, PR exists, mergeable), summarize PR for human confirmation, squash-merge only after explicit OK, then watch the Release run. - "open a new version": pull main, branch out release/x.y.z, bump via `pnpm version --no-git-tag-version`, push, open PR. Also drops the now-completed claude-proxy → AgentMind rename status note and fixes the storage path to ~/.agentmind/. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CI broken on 0.1.1 (typecheck ran before vite/router-plugin had a
chance to write `src/routeTree.gen.ts`, so tsc could not resolve any
route module). Workflow now builds first, then typechecks.
Functionally identical to 0.1.1 for end users — bump exists purely to
re-exercise the CI publish path.
Test plan
Made with Cursor