Skip to content

chore: strip comments from compose files#570

Open
ilyanfraimbault wants to merge 1 commit into
developfrom
chore/569-strip-compose-comments
Open

chore: strip comments from compose files#570
ilyanfraimbault wants to merge 1 commit into
developfrom
chore/569-strip-compose-comments

Conversation

@ilyanfraimbault

Copy link
Copy Markdown
Owner

Declutter the docker compose files (compose.yaml / dev / qa / prod) by removing comments, per maintainer request. Behaviour unchanged — docker compose config valid on all four; git history retains the notes.

Closes #569

Declutter the docker compose files per maintainer request; behaviour unchanged
(git history retains the notes). Closes #569
Comment thread compose.qa.yaml
Comment thread compose.prod.yaml

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — chore: strip comments from compose files

Nettoyage cosmétique demande par le mainteneur. Aucun comportement modifie, les quatre fichiers compose restent valides. Pas de point bloquant.

Suggestions (non bloquantes) :

  • compose.qa.yaml L125 : NUXT_SESSION_COOKIE_SECURE/TRUST_PROXY perdent leur explication de posture HTTP directe sans TLS. Un futur mainteneur pourrait les passer a true en croyant aligner sur prod. Suggere de deplacer ce contexte dans le README QA.

  • compose.prod.yaml L155 (et fichiers similaires) : la contrainte MONGO_USER/MONGO_PASSWORD alphanumeriques (interpoles bruts dans l URI MongoDB) est supprimee partout. Pas de bug immediat, mais un operateur utilisant des caracteres speciaux obtiendra une URI malformee difficile a diagnostiquer. Suggere de le noter dans .env.example ou le README de deploiement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: strip comments from compose files

1 participant