fix(registry): allow roll-forward from unresolved latest - #780
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe release script adds raw registry tag lookup, supports requests without payloads, and uses raw ChangesRegistry tag promotion
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Promotion
participant release_tag_version
participant RegistryAPI
participant resolve_version
Promotion->>release_tag_version: Read raw latest and next tags
release_tag_version->>RegistryAPI: List worker versions
RegistryAPI-->>release_tag_version: Return version metadata
release_tag_version-->>Promotion: Return tag pointers
Promotion->>RegistryAPI: Submit promotion request
Promotion->>release_tag_version: Verify raw latest tag
Promotion->>resolve_version: Verify resolved latest version
Poem
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 57 skipped (no docs/).
Four for four. Nicely done. |
What changed
latestandnextRegistry tag pointers for promotion preconditionsWhy
A provider promotion could not roll forward because resolving the old
latestdependency graph failed after a shared dependency had already advanced. The Registry still had valid raw tag pointers and a compatiblenextcandidate, but preflight stopped before the guarded tag update.Impact
The exact-version promotion executor can recover this ordering failure without weakening its expected-current-tag or expected-candidate checks. A successful promotion still has to resolve the resulting
latestgraph to the requested version.Validation
10 passedintest_registry_release.py174 passedacross.github/scripts/testspython3 -m compileall -q .github/scripts/registry_release.pygit diff --checkClassification:
no-ticket(CI/release recovery).Summary by CodeRabbit
Bug Fixes
Tests