(MOT-4299) fix(ci): unbreak cold registry-lane harness e2e builds - #739
Conversation
Since the daily lane moved to coverage: false, save-if driven by the coverage input meant no run ever wrote the plain harness-e2e key, so every registry-lane build job compiled and downloaded from scratch. Save both keys so daily and deployed builds restore a warm cache.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
skill-check — worker0 verified, 55 skipped (no docs/).
Four for four. Nicely done. |
|
Warning Review limit reached
Next review available in: 53 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe workflow now saves the selected Rust cache key for both coverage and regular builds. The cache save condition is no longer limited to coverage runs. ChangesRust cache workflow
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Since #686 embedded the harness console UI, harness/build.rs needs pnpm whenever the crate compiles from scratch. The Test/Lint E2E crate steps compile harness in every stack mode, but Setup pnpm/Node were gated to source mode, so the first cold registry-lane build (today's daily) panicked with 'pnpm not found on PATH'.
Today's daily (run 31153706659) failed "Test E2E crate" — reproducibly, including on re-run. Two defects compounded:
harness/build.rsneeds pnpm, but registry mode never sets it up. Since (MOT-4327) feat(harness): live context accounting with a console chip #686 embedded the console UI, compilingharnessfrom scratch runs the UI build.Test E2E crate/Lint E2E cratecompileharness(dep ofharness-e2e) in every stack mode, butSetup pnpm/Setup Nodewere gated tostack_mode == 'source'→pnpm not found on PATHpanic on the first cold registry-lane build after (MOT-4327) feat(harness): live context accounting with a console chip #686. Fixed by making both steps unconditional.The plain
harness-e2ecache key was never saved.save-if: ${{ inputs.coverage }}meant only coverage runs saved, and since (MOT-4299) fix(ci): run daily Harness benchmarks against Registry #735 moved the daily tocoverage: false, every registry-lane build compiled and downloaded everything from scratch (which is what exposed defect 1). Fixed withsave-if: true.The e2e crate itself is healthy: 91/91 tests pass warm and cold on stable 1.97.1 (with pnpm on PATH).
_harness-integration.ymlis not affected —harness-integrationhas no path dep onharness.After merge, the next scheduled daily (or a
workflow_dispatch) picks this up.