(MOT-3980) fix(shell): expose coder functions in zero-config mode - #481
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe shell now builds and registers the coder code surface regardless of filesystem jail status. Unjailed configurations use fallback resolver roots consisting of the canonicalized current directory and ChangesCoder surface availability
Estimated code review effort: 3 (Moderate) | ~20 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 41 skipped (no docs/).
Four for four. Nicely done. |
Summary
Make all nine
coder::*file tools available when the shell worker uses its shipped zero-config policy.The coder resolver now uses its existing working-directory plus
/tmpfallback whenfs.host_rootsis empty, while explicit roots continue to override that fallback. Hot reloads can also move safely between configured roots and the zero-config fallback.Why
The default shell configuration deliberately leaves
fs.host_rootsempty, but startup and reload contained separate jail checks that skipped the entire coder surface. As a result, healthy harness sessions had no coder file tools even though the resolver already supported a safe fallback.Developer experience
A fresh local stack now exposes coder tools without requiring operators to discover and configure filesystem roots first. Harness-selected workspaces remain available through the trusted per-session filesystem scope.
This does not grant parent directories automatically or weaken
shell::fs::*confinement. Attempts to leave the selected workspace still require an explicit folder-access grant.Verification
cargo fmt --manifest-path shell/Cargo.toml -- --checkcargo test --manifest-path shell/Cargo.toml --lib configuration::tests::— 17 passedcargo test --manifest-path shell/Cargo.tomlcoder::*functions registered after restarting only the shell workercoder::read-fileread a file from the selected workspace outside the worker's static fallback rootsFixes MOT-3980
Summary by CodeRabbit
/tmpwhen no explicit base paths are configured.