Skip to content

chore: Prepare move to igraph 0.10#861

Closed
krlmlr wants to merge 2 commits intomainfrom
pre-igraph-0.10
Closed

chore: Prepare move to igraph 0.10#861
krlmlr wants to merge 2 commits intomainfrom
pre-igraph-0.10

Conversation

@krlmlr
Copy link
Copy Markdown
Contributor

@krlmlr krlmlr commented Jun 28, 2023

Extracted from #840.

@Antonov548: I wonder if we can do "small bets" here again: refactor code before actually moving to igraph 0.10. Would that approach work in principle?

I tried adding more commits from that PR, but compilation a40lready broke.

@krlmlr krlmlr changed the title Prepare move to igraph 0.10 chore: Prepare move to igraph 0.10 Jun 28, 2023
@krlmlr
Copy link
Copy Markdown
Contributor Author

krlmlr commented Jun 28, 2023

Oh, the tests fail now. That's too bad.

@krlmlr krlmlr closed this Jun 28, 2023
@Antonov548
Copy link
Copy Markdown
Contributor

Oh, the tests fail now. That's too bad.

I can check why tests are failed in this case. But I think it could be because R functions didn't change accordingly.

I would love to move by small pull request. But sometimes it's hard to seperate such small parts from the big list of commpilation errors. And I think it can slow down the process a lot.

@krlmlr
Copy link
Copy Markdown
Contributor Author

krlmlr commented Jun 28, 2023

Yes, I see this. Let's keep going with the big PR then.

@Antonov548
Copy link
Copy Markdown
Contributor

Yes, I see this. Let's keep going with the big PR then.

Also I would like to run some static analyzer after fix coompilation errors to get rid of not used functions and declaration in rinterface_extra.c.

@szhorvat
Copy link
Copy Markdown
Member

Once you set up CMake, static analysers will be much easier to use. For example, CMake can generate Xcode project files, and you can use Xcode's Project -> Analyze feature, which presents the results in a very easy to understand format.

For the C core, we are currently using https://scan.coverity.com/, which is also very good.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants