Skip to content

fix: Rename merges to cluster_merges in output of cluster_leading_eigen()#820

Merged
krlmlr merged 3 commits intomainfrom
b-797-cluster-merges
May 28, 2023
Merged

fix: Rename merges to cluster_merges in output of cluster_leading_eigen()#820
krlmlr merged 3 commits intomainfrom
b-797-cluster-merges

Conversation

@krlmlr
Copy link
Copy Markdown
Contributor

@krlmlr krlmlr commented May 27, 2023

Closes #797.

@szhorvat
Copy link
Copy Markdown
Member

While function names now avoid dots, "key names" (what are the names that come after $ called in R?) still typically use them. What's conventional in R? Is cluster.merges or cluster_merges better here?

@krlmlr
Copy link
Copy Markdown
Contributor Author

krlmlr commented May 27, 2023

Element names? Names of a vector?

Let's stick with the existing convention, consistency is key. If written from scratch, we could use underscores, dots are fine too. Spaces or other non-syntactic characters would make things difficult.

@krlmlr krlmlr merged commit 4a7df66 into main May 28, 2023
@krlmlr krlmlr deleted the b-797-cluster-merges branch May 28, 2023 05:46
krlmlr added a commit that referenced this pull request Jun 15, 2023
…r_leading_eigen()` (#820)"

This reverts commit 4a7df66, reversing
changes made to 003fd47.

CC @szhorvat.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cluster_leading_eigen() output is incompatible with dendrogram construction

2 participants