chore: Ensure we're always using named indexes to access the internal data structure#784
chore: Ensure we're always using named indexes to access the internal data structure#784
Conversation
| ## Drop all attributes, we don't want to deal with them, TODO | ||
| graph2 <- graph | ||
| graph2[[9]] <- list(c(1, 0, 1), list(), list(), list()) | ||
| graph2[[igraph_t_idx_attr]] <- list(c(1, 0, 1), list(), list(), list()) |
There was a problem hiding this comment.
@krlmlr I think it should be replaced with some Call of C function. Should it be in this pull request?
There was a problem hiding this comment.
I agree. Yes, please.
I wonder why the tests fail in CI/CD. Can you please try reverting the change to the .svg file?
There was a problem hiding this comment.
It seems slightly better to have all .Call() calls in separate R functions. So, this can be a call to a function whose only purpose is to .Call() a C function.
There was a problem hiding this comment.
I wonder why the tests fail in CI/CD. Can you please try reverting the change to the
.svgfile?
There is one failing test which is related to update old graph. I think it should be fixed after all properties will be fine. For now I just ignored it locally.
CC: test-old-data-type.R
There was a problem hiding this comment.
You can use skip() to officially skip the test for now, I had used that in this PR too.
krlmlr
changed the title
|
Thanks! |
2 participants
This is a work in progress. Each commit should pass all tests.
Pre-work for #768 and #783.