Conversation
krlmlr
reviewed
Oct 19, 2025
Contributor
krlmlr
left a comment
krlmlr
left a comment
There was a problem hiding this comment.
Thanks for looking into it!
tests/testthat/test-centrality.R
Outdated
| all.equal(as.vector(M %*% v), lambda * v) | ||
| } | ||
|
|
||
| is.good <- function(M, v, lambda) { |
Contributor
There was a problem hiding this comment.
The original implementation is better if renamed to expect_principal() and expect_ev() . We could pass the loop index i as a label or something, for clearer messages.
tests/testthat/test-centrality.R
Outdated
Comment on lines
+162
to
+165
| G <- sample_gnm(10, sample(15:25, 1), directed = FALSE) | ||
| while (!is_connected(G)) { | ||
| G <- sample_gnm(10, sample(15:25, 1), directed = FALSE) | ||
| } |
Contributor
There was a problem hiding this comment.
A repeat {} with a break avoids duplication?
krlmlr
added a commit
that referenced
this pull request
Oct 25, 2025
igraph 2.2.1 - Fix ASAN checks. - Add protection to fix rchk error. - Improve centralitystress test (#2214). - Fix flaky test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2202
Doing this change on main, in the hope that we will then rebase the #2058 PR, because I don't want to have too many moving parts in #2058.