Skip to content

chore: add air code formatting#1869

Merged
schochastics merged 60 commits intomainfrom
f-air
Jun 13, 2025
Merged

chore: add air code formatting#1869
schochastics merged 60 commits intomainfrom
f-air

Conversation

@schochastics
Copy link
Copy Markdown
Contributor

@schochastics schochastics commented Jun 10, 2025 •
edited
Loading

fix #1734

@DavisVaughan
Copy link
Copy Markdown

DavisVaughan commented Jun 10, 2025 •
edited
Loading

Feel free to let me know if you run into any issues here or have any specific questions, I'd love to see igraph using Air 😄

@DavisVaughan
Copy link
Copy Markdown

DavisVaughan commented Jun 10, 2025

Also make sure you've got the just released Air 0.7.0! It was released Friday but does a much better job with some if statements in particular.

This was referenced Jun 10, 2025
Merged
Closed
@schochastics
Copy link
Copy Markdown
Contributor Author

schochastics commented Jun 10, 2025

Also make sure you've got the just released Air 0.7.0! It was released Friday but does a much better job with some if statements in particular.

I am using the Positron extension and it says version 0.14.0 which I updated three days ago so i assume I am on the newest version?

@DavisVaughan
Copy link
Copy Markdown

DavisVaughan commented Jun 10, 2025

Yea that's right

@schochastics schochastics mentioned this pull request Jun 12, 2025
Closed
@schochastics schochastics requested review from krlmlr and maelle and removed request for maelle June 12, 2025 12:54
@schochastics schochastics marked this pull request as ready for review June 12, 2025 12:54
@schochastics
Copy link
Copy Markdown
Contributor Author

schochastics commented Jun 12, 2025

I checked everything manually and I think it should be fine now but please have a superficial look

krlmlr
krlmlr approved these changes Jun 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great! Can you please revert and merge?

R/utils-s3.R Outdated
switch(fn,
is_interactive = return(rlang::is_interactive)
)
if (
Copy link
Copy Markdown
Contributor

@krlmlr krlmlr Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be exempt from styling. I wonder if this is now in an "rlang standalone" file, these are exempt by default. Let's revert here and review later.

Copy link
Copy Markdown

@DavisVaughan DavisVaughan Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/r-lib/rlang/blob/main/R/standalone-s3-register.R

@schochastics schochastics enabled auto-merge (squash) June 13, 2025 03:48
@schochastics schochastics merged commit e6d5e88 into main Jun 13, 2025
6 checks passed
@schochastics schochastics deleted the f-air branch June 13, 2025 04:05
schochastics added a commit that referenced this pull request Aug 25, 2025
@schochastics
chore: add air code formatting (#1869)
448a5d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krlmlr krlmlr krlmlr approved these changes

@maelle maelle Awaiting requested review from maelle

+1 more reviewer

@DavisVaughan DavisVaughan DavisVaughan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hackathon-topic 📆

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

protect literals from Air

4 participants

@schochastics @DavisVaughan @krlmlr @maelle