test: merged and refactored games.R tests

[schochastics]

also cleaned up code in games.R (eg stop -> cli::cli_abort)

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[szhorvat]

When you add these tests, I suggest you look at the functionality with a critical eye. If it seems problematic, or there are obvious possibilities for improvements, this is a good time to signal that. I am referring to things that affect the C library, and are not specific to R only. There is a theoretical possibility to make breaking changes before the 1.0 release.

We have some old functions that are not up to the same quality standards that we try to uphold these days.

[maelle]

Thank you!! Some comments on error messages, thanks for taking this on!

[schochastics]

When you add these tests, I suggest you look at the functionality with a critical eye. If it seems problematic, or there are obvious possibilities for improvements, this is a good time to signal that. I am referring to things that affect the C library, and are not specific to R only. There is a theoretical possibility to make breaking changes before the 1.0 release.

We have some old functions that are not up to the same quality standards that we try to uphold these days.

Yes that is also something I try to do in parallel. I ping if I find something