test: Test handling of "return.vs.es" in several functions#1610
Merged
krlmlr merged 4 commits intoigraph:mainfrom Dec 1, 2024
stibu81:fix_return.vs.es
Merged
test: Test handling of "return.vs.es" in several functions#1610krlmlr merged 4 commits intoigraph:mainfrom stibu81:fix_return.vs.es
"return.vs.es" in several functions#1610krlmlr merged 4 commits intoigraph:mainfrom
stibu81:fix_return.vs.es
Conversation
Contributor
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
"return.vs.es" in several functions
Contributor
|
Thanks a lot, just in time for the release! |
Contributor
Author
|
Could you comment on the other issue I found? It could be fixed quickly if you agree that it is a mistake. |
Contributor
|
Thanks, good catch, missed that. This is a new issue and a potentially breaking change, let's handle this separately. |
Contributor
Author
|
Should I open an issue where this can be discussed? |
Contributor
|
Please do, thank you. Chances are that other functions are affected here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes the fix of #1605 and adds tests.
Since the tests of
neighbors()were based onas_adj_list(), I have extended the test of the latter to also run withreturn.vs.es = FALSE. I extended the tests ofneighbors()and added tests foradjacent_vertices()andincident_edges().I found another small issue related to this one that I think is a mistake. But I am not entirely sure that it is, so I would like to have confirmation before I fix it:
as_adj_edge_list()does not respect the settingreturn.vs.esand always returnsigraph.esobjects. Could someone please confirm that this is indeed not the expected behaviour. I could then fix this and update the pull request. Or should I open a new issue for this?