Skip to content

test: Test handling of "return.vs.es" in several functions#1610

Merged
krlmlr merged 4 commits intoigraph:mainfrom
stibu81:fix_return.vs.es
Dec 1, 2024
Merged

test: Test handling of "return.vs.es" in several functions#1610
krlmlr merged 4 commits intoigraph:mainfrom
stibu81:fix_return.vs.es

Conversation

@stibu81
Copy link
Copy Markdown
Contributor

@stibu81 stibu81 commented Dec 1, 2024

This completes the fix of #1605 and adds tests.

Since the tests of neighbors() were based on as_adj_list(), I have extended the test of the latter to also run with return.vs.es = FALSE. I extended the tests of neighbors() and added tests for adjacent_vertices() and incident_edges().

I found another small issue related to this one that I think is a mistake. But I am not entirely sure that it is, so I would like to have confirmation before I fix it: as_adj_edge_list() does not respect the setting return.vs.es and always returns igraph.es objects. Could someone please confirm that this is indeed not the expected behaviour. I could then fix this and update the pull request. Or should I open a new issue for this?

@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app bot commented Dec 1, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr krlmlr changed the title Fix and test handling of return.vs.es in several functions test: Test handling of "return.vs.es" in several functions Dec 1, 2024
@krlmlr krlmlr merged commit 566ebf0 into igraph:main Dec 1, 2024
@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Dec 1, 2024

Thanks a lot, just in time for the release!

@stibu81
Copy link
Copy Markdown
Contributor Author

stibu81 commented Dec 1, 2024

Could you comment on the other issue I found? It could be fixed quickly if you agree that it is a mistake.

@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Dec 1, 2024

Thanks, good catch, missed that. This is a new issue and a potentially breaking change, let's handle this separately.

@stibu81
Copy link
Copy Markdown
Contributor Author

stibu81 commented Dec 1, 2024

Should I open an issue where this can be discussed?

@stibu81 stibu81 deleted the fix_return.vs.es branch December 1, 2024 21:06
@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Dec 1, 2024

Please do, thank you. Chances are that other functions are affected here.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants