Prepare for libxml2 depending on bcrypt, use pkg-config.#1556
Merged
aviator-app[bot] merged 1 commit intoigraph:mainfrom Oct 17, 2024
Merged
Prepare for libxml2 depending on bcrypt, use pkg-config.#1556aviator-app[bot] merged 1 commit intoigraph:mainfrom
aviator-app[bot] merged 1 commit intoigraph:mainfrom
Conversation
Contributor
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
Contributor
|
Thanks! |
aviator-app
bot
force-pushed
the
link-bcrypt-pkg-config
branch
from
23505ee to
97ee8aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some upcoming version of Rtools will ship with libxml2 which will depend on bcrypt. This patch updates linking on Windows for that. Also, the patch conditionally uses pkg-config (when available, which it is in current version of Rtools) to establish the dependencies so that such upgrades in the future should not require changes in the package.