Skip to content

lifecycle: erdos.renyi.game() and random.graph.game() soft deprecation#1509

Merged
aviator-app[bot] merged 7 commits intomainfrom
erdos.renyi.game
Sep 19, 2024
Merged

lifecycle: erdos.renyi.game() and random.graph.game() soft deprecation#1509
aviator-app[bot] merged 7 commits intomainfrom
erdos.renyi.game

Conversation

@maelle
Copy link
Copy Markdown
Contributor

@maelle maelle commented Sep 19, 2024

Part of #1508

@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app bot commented Sep 19, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@maelle maelle added lifecycle Deprecating old APIs mergequeue labels Sep 19, 2024
@aviator-app aviator-app bot merged commit 4ba2300 into main Sep 19, 2024
@aviator-app aviator-app bot deleted the erdos.renyi.game branch September 19, 2024 09:45
@szhorvat
Copy link
Copy Markdown
Member

szhorvat commented Sep 19, 2024

I suggest keeping erdos.renyi.game() for quite a long time, as there might be a lot of code (not packages, but analysis code, e.g. bundled with research papers) that relies on it. People may get frustrated and complain about reproducibility if the function is removed too early. Note that I'm talking about removal, not deprecation.

As for deprecation, the sooner the better: it's great to see that being done.

As for random.graph.game(), this one has been outdated for a long long time, and it's much less used. I think it can be removed much earlier than erdos.renyi.game().

To be clear, this is based more on hunches than measurements (though you've seen the numbers too from GitHub searches).

@maelle
Copy link
Copy Markdown
Contributor Author

maelle commented Sep 19, 2024

Yeah the numbers from GitHub search made me realize it shouldn't go away too soon 😅

@maelle
Copy link
Copy Markdown
Contributor Author

maelle commented Sep 19, 2024

but now it's in the lifecycle system so we won't forget about it

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lifecycle Deprecating old APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants