chore: add some argument checking to add_shape()#1478
Merged
aviator-app[bot] merged 1 commit intomainfrom Aug 30, 2024
Merged
Conversation
Contributor
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
szhorvat
reviewed
Aug 27, 2024
aviator-app
bot
force-pushed
the
todo-shapes
branch
from
af5b280 to
24cb69c
Compare
Contributor
|
This pull request failed to merge: some CI status(es) failed. Once the issues are resolved, remove the Failed CI(s): Check ubuntu-20.04 (oldrel-4), Check ubuntu-20.04 (oldrel-2), Check ubuntu-20.04 (oldrel-3) |
krlmlr
changed the title
add_shape()
krlmlr
approved these changes
Aug 29, 2024
Contributor
krlmlr
left a comment
krlmlr
left a comment
There was a problem hiding this comment.
Thanks, nice! We saw that we need {.help igraph::add_shape}, also elsewhere?
Contributor
|
Checks still fail. |
aviator-app
bot
force-pushed
the
todo-shapes
branch
from
f1e24fc to
62feb78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just removing a TODO :-)