fix: fix includig diagonal elements in dense adjacency matrices#1437
fix: fix includig diagonal elements in dense adjacency matrices#1437aviator-app[bot] merged 2 commits intomainfrom
Conversation
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
92b11f2 to
926c6d8
Compare
|
@maelle: Can you please add a test to this PR? Looks good to me otherwise. |
|
On it now 😸 |
38db0f3 to
8a8c6e3
Compare
|
All test cases except the fourth one fail for the main branch. 🎉 |
|
This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Once the issues are resolved, remove the Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts). |
8a8c6e3 to
66d0e67
Compare
Fixes #1429
This does fix the issue reported in #1429, and is ready to go right now in that sense. But you may want to polish it up to prepare the ground for future improvements. I leave it in your hands @Antonov548 @krlmlr
You may also want to add some tests (weighted and unweighted undirected case).