feat: export .from() etc. with behavior similar to dplyr::across()#1436
feat: export .from() etc. with behavior similar to dplyr::across()#1436aviator-app[bot] merged 2 commits intomainfrom
.from() etc. with behavior similar to dplyr::across()#1436Conversation
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
krlmlr
left a comment
There was a problem hiding this comment.
Thanks, will try locally.
These days, I'd use generated code instead of clever code like this. One drawback is that environment(.from) is not the igraph environment; to achieve this, we'd need even cleverer code.
|
Would you like to add examples of correct usage, or a link to the help topic where they are described? Perhaps even merge with that existing help topic (if it, well, exists)? |
Do we need to tackle this here? |
Painstakingly added the links. 😁 |
.from() etc. with behavior similar to dplyr::across().from() etc. with behavior similar to dplyr::across()
krlmlr
left a comment
There was a problem hiding this comment.
Let's remove the keywords internal at some point, shouldn't be a blocker for now.
|
I don't think they should be external though. Users should only get to them from the error message. |
Fix #1435
A drawback: the tree "nei" functions are actually only for index sequences but I let them output the same message. Is that bad?
Also, the help link does not work for me but it looks correct, maybe just a problem with my IDE version? I'd be grateful if you could try it on your side.