Skip to content

feat: export .from() etc. with behavior similar to dplyr::across()#1436

Merged
aviator-app[bot] merged 2 commits intomainfrom
from
Aug 13, 2024
Merged

feat: export .from() etc. with behavior similar to dplyr::across()#1436
aviator-app[bot] merged 2 commits intomainfrom
from

Conversation

@maelle
Copy link
Copy Markdown
Contributor

@maelle maelle commented Jul 18, 2024

Fix #1435

A drawback: the tree "nei" functions are actually only for index sequences but I let them output the same message. Is that bad?

Also, the help link does not work for me but it looks correct, maybe just a problem with my IDE version? I'd be grateful if you could try it on your side.

@maelle maelle requested a review from krlmlr July 18, 2024 12:22
@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app bot commented Jul 18, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Copy Markdown
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will try locally.

These days, I'd use generated code instead of clever code like this. One drawback is that environment(.from) is not the igraph environment; to achieve this, we'd need even cleverer code.

@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Jul 18, 2024

Would you like to add examples of correct usage, or a link to the help topic where they are described? Perhaps even merge with that existing help topic (if it, well, exists)?

@maelle
Copy link
Copy Markdown
Contributor Author

maelle commented Jul 19, 2024

These days, I'd use generated code instead of clever code like this. One drawback is that environment(.from) is not the igraph environment; to achieve this, we'd need even cleverer code.

Do we need to tackle this here?

@maelle
Copy link
Copy Markdown
Contributor Author

maelle commented Jul 19, 2024

@maelle
Copy link
Copy Markdown
Contributor Author

maelle commented Jul 19, 2024

Would you like to add examples of correct usage, or a link to the help topic where they are described? Perhaps even merge with that existing help topic (if it, well, exists)?

Painstakingly added the links. 😁

@maelle maelle requested a review from krlmlr July 19, 2024 15:23
@krlmlr krlmlr changed the title feat: export .from() etc. with behavior similar to dplyr::across() feat: export .from() etc. with behavior similar to dplyr::across() Jul 19, 2024
Copy link
Copy Markdown
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the keywords internal at some point, shouldn't be a blocker for now.

@maelle
Copy link
Copy Markdown
Contributor Author

maelle commented Aug 13, 2024

I don't think they should be external though. Users should only get to them from the error message.

@aviator-app aviator-app bot merged commit a11c93a into main Aug 13, 2024
@aviator-app aviator-app bot deleted the from branch August 13, 2024 09:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export .from etc. with behavior similar to dplyr::across()

2 participants